The latest updates on your projects. Learn more about Vercel for Git ↗︎

Thanks for your contribution.

But I think this is by design, and you can modify it through the theme properties.

      :root {
        --heading-line-height: normal;
      }

I'd tend to include this fix, as by default I would expect line-height to be automatic by default in all Browsers and not require additional changes.

@sy-records ah, thanks; I did not check for an existing variable. I set the global variable and it did indeed fix the problem but as @paulhibbitts commented, I would expect the text to look correct by default in all browsers. I've moved the change to be the default --heading-line-height variable value so it can still be overridden by themes.

Thanks @dajrivera , now that I think about it I may also have run across this issue earlier when trying different fonts out with v5 and noticing I needed to then further adjust line-height to avoid slight cut-off one some particular ones.

I think there might be a problem.

@sy-records looks like the h2 bottom-margin is calculated and was the reason for the prior "Unit required" comment; using value normal here broke that calculation. I've updated the bottom-margin calculation using the line height unit instead. At this point the bottom margin was too large so I included a local line-height-multiplier to reduce the margin size as a workaround. Let me know if you can think of a better alternative or a more appropriate method to implement this.

Looks good to me in Edge. I can test Chrome, Firefox, and Safari tomorrow.

Good catch @sy-records , my apologies for not viewing additional pages in the PR preview... I will be more careful in the future.

From my perspective I hope that the resulting spacing unit adjustments match the spacing as originally specified by John Hildenbiddle as much as possible.

@sy-records @paulhibbitts Please review this again. I've changed the approach to only allow y overflow on h1 & h2 headings. Tested this on Edge, Chrome, Firefox, and Safari and all display the fonts without issue without additional changes to the rest of the UI.

If OK, let me know I can clean up the commits.

Thanks @dajrivera , but it looks like it strays quite a bit from the original theme spacing, re: H2 border and spacing.

Here is the current Docsify Preview:

And here is the latest PR Preview I see:

@paulhibbitts sorry about that, seems the calc function went missing when reverting a change that was affecting safari; I've re-added it again.

No worries, now the preview looks identical to John's original layout ✅

Here is the current Docsify Preview:

And here is the updated PR Preview:

All looks good to me!